[DONE] Browse by Album/Artist/Genre

[ACX]

Hi everyone,
I just pulled an update that introduces one of the most requested features which were missing at the current stage of development of the RuneUI, the ability of browsing MPD's Library by Album/Artist/Genre beyond the default "by File" mode.

This is a first implementation and, although almost fully functional, is not 100% perfect. Anyway it seemed to me usable enough to be committed and tested by users.

Browse by Album/Artist/Genre feature added to the Library

RuneAudio_-_RuneUI_-_2014-12-10_15.30.58.png (59.28 KiB) Viewed 3310 times

A known bug is that performing an action from the contextual dropdown menu on a Unknown Album/Artist/Genre entry doesn't give the expected results. This only happens when your files don't have the media tags set properly, so it's an an acceptable compromise for the moment.

Commits involved:

1. https://github.com/RuneAudio/RuneUI/com ... 70388714c9
2. https://github.com/RuneAudio/RuneUI/com ... 9c262ebb5a
3. https://github.com/RuneAudio/RuneUI/com ... 3370e9e3f7
4. https://github.com/RuneAudio/RuneUI/com ... d0b2b85cfe
5. https://github.com/RuneAudio/RuneUI/com ... 3e76fe1fbd
6. https://github.com/RuneAudio/RuneUI/com ... 6b79c20ca6
7. https://github.com/RuneAudio/RuneUI/com ... cb541fb293

INSTRUCTIONS TO UPDATE:
how-to-update-the-runeui-via-git-t547.html

Please test this and report any unexpected behaviours.

[Stwert]

Sweet. Looking forward to trying this out.

[ryanmcclure]

Looks awesome!!! I won't be able to test this out for a while (away from my apartment until tonight). Is the browse by artist just regular artist? Or is there functionality for browsing by album artist? Thanks for the hard work!

[skrodahl]

Doing the git pull, I got the following errors:

Code: Select all

[root@runeaudio ~]# cd /var/www/
[root@runeaudio www]# git pull
Updating d84ea1e..398764a
error: Your local changes to the following files would be overwritten by merge:
   app/libs/runeaudio.php
   app/templates/playback.php
   assets/js/runeui.js
   db/index.php
Please, commit your changes or stash them before you can merge.
Aborting

I did not change any of these files manually, the only "odd" thing I've done is to add one bookmark.

I decided to do a 'git reset --hard', and try again. Voila:

Code: Select all

[root@runeaudio www]# git reset --hard
HEAD is now at d84ea1e Solved parsing issue when metadata contains colons
[root@runeaudio www]# git pull
Updating d84ea1e..398764a
Fast-forward
 app/libs/runeaudio.php         | 11 ++++++++++-
 app/templates/playback.php     | 12 ++++++------
 assets/css/runeui.css          |  2 +-
 assets/js/runeui.js            | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------
 assets/js/runeui.min.js        |  4 ++--
 assets/less/runeui-custom.less |  4 ++--
 db/index.php                   |  2 +-
 7 files changed, 89 insertions(+), 43 deletions(-)
[root@runeaudio www]# curl -s -X GET 'http://localhost/clear'
PHP OPCACHE CLEARED

As far as I can see, it did not break anything. But wow! I got the Albums/Artists/Genres. Seems to work beautifully.

The only downside is that it made me wish for rearrangable icons in the library, and the ability to hide the ones that I don't use. They are useful for easy access to the settings, but having the opportunity to disable them in the settings menu would be a nice compromise. Then it would be a conscious user decision.

[ACX]

Doing the git pull, I got the following errors:

Danm, that's weird. We have to investigate that...

The only downside is that it made me wish for rearrangable icons in the library, and the ability to hide the ones that I don't use. They are useful for easy access to the settings, but having the opportunity to disable them in the settings menu would be a nice compromise. Then it would be a conscious user decision.

It happens that I just posted about that, thinking the same
setup-the-library-home-screen-button-t637.html#p4197

[skrodahl]

It happens that I just posted about that, thinking the same
setup-the-library-home-screen-button-t637.html#p4197

I should have kept on reading. Glad to see that you're thinking the same.

[popov]

Hi

It's working ....Fine

Thank you

[ryanmcclure]

Hi ACX,

Any possibility of having Album Artist be a search criterion instead of Artist (either a toggle or another button in the library?) For those of us who have a lot of compilation albums or classical albums, this would be incredibly helpful

[ACX]

@ryanmcclure can you bring a practical example of how you expect that to work instead of the current way?

[ryanmcclure]

@ryanmcclure can you bring a practical example of how you expect that to work instead of the current way?

Absolutely. For example, here is my list of my "Album Artists," or artists who are attributed as such on MusicBrainz (A small sample):

Armstrong, Louis
Bennett, Tony
Coltrane, John
Crosby, Bing
Davis, Miles
Fitzgerald, Ella
Jones, Thad
Martin, Dean
Miller, Glenn
Porter, Cole
Sinatra, Frank
Various Artists

However, here's what RuneUI lists as "Artists:"

Al Bowlly & Lew Stone & His Band
Ambrose and His Orchestra & Sam Brown
Billie Holiday
Bing Crosby
Dean Martin
Duke Ellington & His Orchestra
Frank Sinatra
John Coltrane
...
Louis Armstrong & Benny Carter and His Orchestra
Louis Armstrong & His All-Stars
Louis Armstrong & The Commanders
Louis Armstrong with Gordon Jenkins & His Orchestra
...

The list goes on and on. As you can see, finding all albums that are attributed to Louis Armstrong can be pretty difficult this way.

Another example (here's the concept, not a list) is for classical compilation CDs, such as "Famous Quartets" by the "Made-up String Quartet." The album artist is the Made-up String Quartet, and that is whom I will search to play the album. However, the artists (according to MusicBrainz, which is how I've tagged my whole library) would be: Mozart, Beethoven, Schubert, Haydn. So, the current Artists view would only allow me to search the album in fragments and not by the artist. If I wanted to listen to everything by the Made-up String Quartet, it would be a bit more annoying to find all these albums. I hope this cleared up my thinking a bit.