[Addon] RuneUI Enhancement

Raspberry Pi related support

Re: [Addon] RuneUI Enhancement

Postby AndyF » 22 Jan 2019, 20:36

Hi R101,

I have one bug found: Scrolling starts on long text - but it don't stop on following short text until page is reloaded. I have to learn more Javascript ;)

Andy
AndyF
 
Posts: 62
Joined: 02 Aug 2015, 07:36
Location: Germany - Bavaria

Re: [Addon] RuneUI Enhancement

Postby R101 » 22 Jan 2019, 21:20

AndyF,

Yes, it works sometimes now. (I turned off Dev mode and cleared the cache this time, as well as rebooting.)

I agree that the scrolling behavior depends on the state of the previous display. If the previous display was static, it keeps this state until the display is refreshed. If the previous display was scrolling, it will scroll the new display at a speed depending on the previous display string length, even if it does not need to scroll.
(Pi 3, Ver. 0.4b build 20170229, JLS I2S over USB)
R101
 
Posts: 185
Joined: 29 Apr 2016, 16:16

Re: [Addon] RuneUI Enhancement

Postby rern » 23 Jan 2019, 10:19

Update 20190123
- Fix missing embedded cover arts bug
- Fix Playback text scrolling bug
- Fix Replace+Play sometimes switched to Playback with empty item

rern
Raspberry Pi 3 > SMSL M8 DAC
GitHub
rern
 
Posts: 315
Joined: 14 Jul 2016, 08:15

Re: [Addon] RuneUI Enhancement

Postby AndyF » 23 Jan 2019, 19:36

Hi rern,

thanks for your update! Your fixes works - RuneUIe gets better and better!

Perhaps - can you merge some of my simple fixes to your code? So it would be less work for me to patch after your update ... But of course it 's your project and your decision.

Thank you anyway in advance,

Andy
Last edited by AndyF on 23 Jan 2019, 21:34, edited 1 time in total.
AndyF
 
Posts: 62
Joined: 02 Aug 2015, 07:36
Location: Germany - Bavaria

Re: [Addon] RuneUI Enhancement

Postby R101 » 23 Jan 2019, 21:02

Hi rern,

Sorry to report that I have lost the metadata scrolling on webradio after this update.
(Pi 3, Ver. 0.4b build 20170229, JLS I2S over USB)
R101
 
Posts: 185
Joined: 29 Apr 2016, 16:16

Re: [Addon] RuneUI Enhancement

Postby AndyF » 23 Jan 2019, 21:12

Hi R101,

no problem here. Cache?

Regards, Andy
AndyF
 
Posts: 62
Joined: 02 Aug 2015, 07:36
Location: Germany - Bavaria

Re: [Addon] RuneUI Enhancement

Postby R101 » 23 Jan 2019, 21:39

I can get it to scroll by repeating the replace and play selection. If I just change stations without doing it twice, it retains the previous scrolling state.

By the way rern, updating retains the library item settings except for the context menu icon.
(Pi 3, Ver. 0.4b build 20170229, JLS I2S over USB)
R101
 
Posts: 185
Joined: 29 Apr 2016, 16:16

Re: [Addon] RuneUI Enhancement

Postby rern » 24 Jan 2019, 06:24

AndyF wrote:...
Perhaps - can you merge some of my simple fixes to your code? So it would be less work for me to patch after your update ...
...

The same album but different cover arts - Songs from the same album normally have the same cover art. A large cover art might cause a noticable delay each time it fetched. Reuse the same cover art without refetching can avoid unnecessary delays.
Back button - It is not better to move it as of your suggestion.

R101 wrote:I can get it to scroll by repeating the replace and play selection. If I just change stations without doing it twice, it retains the previous scrolling state.
...

Please explain the "just change stations without doing it twice" thing.
Raspberry Pi 3 > SMSL M8 DAC
GitHub
rern
 
Posts: 315
Joined: 14 Jul 2016, 08:15

Re: [Addon] RuneUI Enhancement

Postby AndyF » 24 Jan 2019, 06:56

Hi rern,

thanks for your reply!

The same album but different cover arts - Songs from the same album normally have the same cover art. A large cover art might cause a noticable delay each time it fetched. Reuse the same cover art without refetching can avoid unnecessary delays.
Back button - It is not better to move it as of your suggestion.


I have much sampler like "The dome xxx", "Best of rock xxx" and other compilations. Most of them have embedded CoverArt (it was hard work ...). So fetching delay is no problem on this. If there aren´t embedded covers, in most cases there are no online results. I´m using RuneUIe with my mods - no noticeable slowdown. Of course the "Back button" is surely a matter of opinion. I like them left - because nearly every other software I know, has this button on the left side (browsers, database etc.).

I modded enhancestatus.php to correct metadata if you change from a fully tagged mp3 to a bad tagged mp3:

Code: Select all
// no id3tag
         if ( empty( $status[ 'Title' ]) ) {
                 $status[ 'Artist' ] = basename( $dir );
                 $status[ 'Title' ] = $pathinfo[ 'filename' ];
                 $status[ 'Album' ] = '';
         }
         if ( empty( $status[ 'Album' ]) ) {
                 $status[ 'Album' ] = '';
         }
         if ( empty( $status[ 'Artist' ]) ) {
                 $status[ 'Artist' ] = '';
         }

This should produce no side effects.

I´ve uncomment 2 lines in the javascript function "addreplace":
Code: Select all
function addReplace( mode, command, title ) {
         if ( mode === 'wr' ) {
                 //GUI.local = 1;
                 //setTimeout( function() { GUI.local = 0 }, 500 );

         }

This helps to refresh top-buttons on replace-play a webradio, because 'getPlaybackStatus' exits without refresh otherwise. A side-effect: I don´t have such problems like R101 with metadata-scrolling.

regards, Andy
AndyF
 
Posts: 62
Joined: 02 Aug 2015, 07:36
Location: Germany - Bavaria

Re: [Addon] RuneUI Enhancement

Postby Toube » 24 Jan 2019, 07:22

Hi Rern,

Thanks for the update.
I shall have try on the latest version.
Last version I tested I had problems with .cue files etc not being added to playlist etc.
I'll keep you posted.

-Toube
Toube
 
Posts: 106
Joined: 10 Oct 2018, 08:10

support RuneAudio Donate with PayPal

PreviousNext

Return to Raspberry Pi

Who is online

Users browsing this forum: Google [Bot] and 3 guests