[Addon] RuneUI Enhancement

Raspberry Pi related support

Re: [Addon] RuneUI Enhancement

Postby rern » 13 Nov 2018, 10:48

Hi Rod,

Help me debug it.
1. Modify enhance.js to get raw data - SSH command:
Code: Select all
sed -i '/RegExp( datapathindex/ {n;a\
alert( "GUI.currentpath = "+ GUI.currentpath );\
alert( "usbpath = "+ usbpath );\
alert( "name-last = "+ name );\
alert( "datapathindex = "+ datapathindex );\
alert( \$( matcharray[ 0 ] ).html() );
}
' /srv/http/assets/js/enhance.js

2. Refresh browser then test the index bar.
3. Copy-paste or capture the screen alerts.
4. Restore enhance.js:
Code: Select all
sed -i '/^alert/ d' /srv/http/assets/js/enhance.js


rern
Raspberry Pi 3 > SMSL M8 DAC
GitHub
rern
 
Posts: 273
Joined: 14 Jul 2016, 08:15

Re: [Addon] RuneUI Enhancement

Postby rlsten » 13 Nov 2018, 15:12

rern wrote:Hi Rod,

Help me debug it.
1. Modify enhance.js to get raw data - SSH command:
Code: Select all
sed -i '/RegExp( datapathindex/ {n;a\
alert( "GUI.currentpath = "+ GUI.currentpath );\
alert( "usbpath = "+ usbpath );\
alert( "name-last = "+ name );\
alert( "datapathindex = "+ datapathindex );\
alert( \$( matcharray[ 0 ] ).html() );
}
' /srv/http/assets/js/enhance.js

2. Refresh browser then test the index bar.
3. Copy-paste or capture the screen alerts.
4. Restore enhance.js:
Code: Select all
sed -i '/^alert/ d' /srv/http/assets/js/enhance.js


rern


Hi rern,

Thanks very much for helping me out with this!

I clicked "E" on the index bar and got the following series of messages:
Code: Select all
GUI.currentpath = NAS/Music_1/Baroque
usbpath = 0
name-last = NAS/Music_1/Baroque/Zelenka
datapathindex = ^E
undefined


Other indices resulted in same output, only the datapathindex changed to the letter I clicked.

Hope this helps!

Thanks again,
Rod
rlsten
 
Posts: 102
Joined: 25 May 2015, 18:06

Re: [Addon] RuneUI Enhancement

Postby klassikmann » 14 Nov 2018, 23:45

There is a disturbing difference between the library view and the playlist view. Let me explain the situation in an example.

In the directory "Jazz/Sanders, Pharoah/Save Our Children" of the USB-disk we find:
Code: Select all
-rw-r--r-- 1 mpd audio  97657400 Apr  8  2018 '01. Save Our Children.flac'
-rw-r--r-- 1 mpd audio 116503657 Apr  8  2018 '02. Midnight in Berkeley Square.flac'
-rw-r--r-- 1 mpd audio 173043460 Apr  8  2018 '03. Jewels of Love.flac'
-rw-r--r-- 1 mpd audio 124762035 Apr  8  2018 '04. Kazuko.flac'
-rw-r--r-- 1 mpd audio 142018167 Apr  8  2018 '05. The Ancient Sounds.flac'
-rw-r--r-- 1 mpd audio 113181577 Apr  8  2018 '06. Far Off Sand.flac'
-rw-r--r-- 1 mpd audio    121639 Apr  8  2018 folder.jpg

The ID3 tags of the flac-files are:
tags.jpg
tags.jpg (69.04 KiB) Viewed 254 times

If I add "Jazz/Sanders, Pharoah/Save Our Children" in the library view the new playlist looks like:
playlist.jpg
playlist.jpg (106.32 KiB) Viewed 254 times
which is consistent with the directory listing above. But if I click in the library view on the directory "Sanders, Pharoah/Save Our Children" the contents look like:
library.jpg
library.jpg (98.52 KiB) Viewed 254 times

You see that the contents of "Sanders, Pharoah/Save Our Children" are sorted according track numbers in the playlist, and alphabetically according title names in the library.
klassikmann
 
Posts: 34
Joined: 27 Apr 2016, 18:36

Re: [Addon] RuneUI Enhancement

Postby rern » 16 Nov 2018, 07:55

Update 20181116
- Fix index bar not reponse on some devices
- Fix list view of *.m3u bug
- Fix sorting file list in Library
- Show local browser Power menu > Screen off button

rern
Raspberry Pi 3 > SMSL M8 DAC
GitHub
rern
 
Posts: 273
Joined: 14 Jul 2016, 08:15

Re: [Addon] RuneUI Enhancement

Postby Toube » 16 Nov 2018, 08:13

rern wrote:Update 20181116
- Fix index bar not reponse on some devices
- Fix list view of *.m3u bug
- Fix sorting file list in Library
- Show local browser Power menu > Screen off button

rern

Super thanks for the effort @rern

-Toube
Toube
 
Posts: 61
Joined: 10 Oct 2018, 08:10

Re: [Addon] RuneUI Enhancement

Postby poly6 » 17 Nov 2018, 02:27

Relatively new to RuneAudio. Running it on my Pi 3b and have been trying out 0.5 with the Rern UI enhancement. I definitely like the look new UI. But one thing I've found that bothers me. I want to use the Genre filter (it's Christmas and I want to listen to Christmas music :D ). But when I choose Genre from the main window, then choose Christmas from the next page, and then choose an Artist from the next page, it shows me *all* the albums for that artist, not just their Christmas albums. This makes the Genre feature not very useful. It *is* sort of working in that the Artists that are shown after I pick Christmas all have Christmas albums. But the filtering should be carried down one more level so that it only shows Christmas albums for that artist.

I've poked around a little in the source code and it seems like this is being done in app/libs/runeaudio.php so this might not be a problem with the UI enhancement but with the underlying system. But I don't mind trying to figure out how to make this work if you point me in the right direction.

Thanks!
poly6
 
Posts: 2
Joined: 31 Oct 2018, 09:41

Re: [Addon] RuneUI Enhancement

Postby klassikmann » 18 Nov 2018, 10:21

Since the last update the size of the cover art is scaled according to the window size.

Example: Big window
BigWindow.jpg
BigWindow.jpg (109.62 KiB) Viewed 157 times

Example: Small window
SmallWindow.jpg
SmallWindow.jpg (47.22 KiB) Viewed 157 times

IMHO this is aesthetically not ideal.
Two possible solutions
  • It is configurable whether the size of the cover art is static, i.e. same size as the time widget, or dynamically scaled to the window size.
  • The time widget will be scaled also.
klassikmann
 
Posts: 34
Joined: 27 Apr 2016, 18:36

Re: [Addon] RuneUI Enhancement

Postby rern » 19 Nov 2018, 14:51

Update 20181120
- Browse genre - album based
- Fix coverart scaling bug
- Improve empty index and directory handling

@poly6
Your point is valid.
Like artist, album artist and composer - now genre is album based as well.

@klassikmann
It's cover art scaling bug.


rern
Raspberry Pi 3 > SMSL M8 DAC
GitHub
rern
 
Posts: 273
Joined: 14 Jul 2016, 08:15

Re: [Addon] RuneUI Enhancement

Postby Toube » 19 Nov 2018, 14:52

rern wrote:Update 20181120
- Browse genre - album based
- Fix coverart scaling bug
- Improve empty index and directory handling

@poly6
Your point is valid.
Like artist, album artist and composer - now genre is album based as well.

@klassikmann
It's cover art scaling bug.


rern

Beautiful :D :D
Toube
 
Posts: 61
Joined: 10 Oct 2018, 08:10

Re: [Addon] RuneUI Enhancement

Postby klassikmann » 19 Nov 2018, 14:59

rern wrote:@klassikmann
It's cover art scaling bug.
Thank you.
klassikmann
 
Posts: 34
Joined: 27 Apr 2016, 18:36

support RuneAudio Donate with PayPal

PreviousNext

Return to Raspberry Pi

Who is online

Users browsing this forum: No registered users and 3 guests